Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ockham
force-pushed
the
fix/block-hooks-rtc-bug
branch
from
264f9bf to
81b84bb
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ingeniumed
left a comment
ingeniumed
left a comment
There was a problem hiding this comment.
Just the one comment about array access otherwise this works well for me. I can't replicate the issue using the instructions in the Gutenberg PR.
Thanks for fixing this here in core!
| if ( null !== $ignored_hooked_blocks_at_root ) { | ||
| // Check wrapper block's metadata for ignored hooked blocks at the root level, and populate the reference parameter if needed. | ||
| $wrapper_block_markup = extract_serialized_parent_block( $content ); | ||
| $wrapper_block = parse_blocks( $wrapper_block_markup )[0]; |
There was a problem hiding this comment.
Should the length be checked here before the first element is accessed? Just out of safety?
2 participants
Fixes WordPress/gutenberg#76176.
Trac ticket: https://core.trac.wordpress.org/ticket/65008
See WordPress/gutenberg#76895 (comment) and WordPress/gutenberg#76895 (comment) for more details.
Testing Instructions
tl;dr: Verify that WordPress/gutenberg#76176 is fixed.
TODO
apply_block_hooks_to_content_from_post_object.I also need to double-check if it has any other unwanted side effects (unit test coverage should help with that).
Use of AI Tools
“Autocomplete”-level assistance when updating unit tests (e.g. for assertion failure messages).
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.